[PATCH] D68650: [AIX][XCOFF][NFC] Change the SectionLen field name of CSect Auxiliary entry to SectionOrLength.

[Jason Liu via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG6453f700f29a: [AIX][XCOFF][NFC] Change the SectionLen field name of CSect Auxiliary entry to… (authored by jasonliu).

Changed prior to commit:
  https://reviews.llvm.org/D68650?vs=223939&id=224078#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68650/new/

https://reviews.llvm.org/D68650

Files:
  llvm/D68650.diff
  llvm/include/llvm/Object/XCOFFObjectFile.h
  llvm/tools/llvm-readobj/XCOFFDumper.cpp


Index: llvm/tools/llvm-readobj/XCOFFDumper.cpp
===================================================================
--- llvm/tools/llvm-readobj/XCOFFDumper.cpp
+++ llvm/tools/llvm-readobj/XCOFFDumper.cpp
@@ -161,9 +161,9 @@
   W.printNumber("Index",
                 Obj.getSymbolIndex(reinterpret_cast<uintptr_t>(AuxEntPtr)));
   if ((AuxEntPtr->SymbolAlignmentAndType & SymbolTypeMask) == XCOFF::XTY_LD)
-    W.printNumber("ContainingCsectSymbolIndex", AuxEntPtr->SectionLen);
+    W.printNumber("ContainingCsectSymbolIndex", AuxEntPtr->SectionOrLength);
   else
-    W.printNumber("SectionLen", AuxEntPtr->SectionLen);
+    W.printNumber("SectionLen", AuxEntPtr->SectionOrLength);
   W.printHex("ParameterHashIndex", AuxEntPtr->ParameterHashIndex);
   W.printHex("TypeChkSectNum", AuxEntPtr->TypeChkSectNum);
   // Print out symbol alignment and type.
Index: llvm/include/llvm/Object/XCOFFObjectFile.h
===================================================================
--- llvm/include/llvm/Object/XCOFFObjectFile.h
+++ llvm/include/llvm/Object/XCOFFObjectFile.h
@@ -113,7 +113,12 @@
 };
 
 struct XCOFFCsectAuxEnt32 {
-  support::ubig32_t SectionLen;
+  support::ubig32_t
+      SectionOrLength; // If the symbol type is XTY_SD or XTY_CM, the csect
+                       // length.
+                       // If the symbol type is XTY_LD, the symbol table
+                       // index of the containing csect.
+                       // If the symbol type is XTY_ER, 0.
   support::ubig32_t ParameterHashIndex;
   support::ubig16_t TypeChkSectNum;
   uint8_t SymbolAlignmentAndType;
Index: llvm/D68650.diff
===================================================================
--- /dev/null
+++ llvm/D68650.diff
@@ -0,0 +1,34 @@
+Index: llvm/include/llvm/Object/XCOFFObjectFile.h
+===================================================================
+--- llvm/include/llvm/Object/XCOFFObjectFile.h
++++ llvm/include/llvm/Object/XCOFFObjectFile.h
+@@ -113,7 +113,12 @@
+ };
+ 
+ struct XCOFFCsectAuxEnt32 {
+-  support::ubig32_t SectionLen;
++  support::ubig32_t
++      SectionOrLength; // If the symbol type is XTY_SD or XTY_CM, the csect
++                       // length.
++                       // If the symbol type is XTY_LD, the symbol table
++                       // index of the containing csect. 
++                       // If the symbol type is XTY_ER, 0.
+   support::ubig32_t ParameterHashIndex;
+   support::ubig16_t TypeChkSectNum;
+   uint8_t SymbolAlignmentAndType;
+Index: llvm/tools/llvm-readobj/XCOFFDumper.cpp
+===================================================================
+--- llvm/tools/llvm-readobj/XCOFFDumper.cpp
++++ llvm/tools/llvm-readobj/XCOFFDumper.cpp
+@@ -213,9 +213,9 @@
+   W.printNumber("Index",
+                 Obj.getSymbolIndex(reinterpret_cast<uintptr_t>(AuxEntPtr)));
+   if ((AuxEntPtr->SymbolAlignmentAndType & SymbolTypeMask) == XCOFF::XTY_LD)
+-    W.printNumber("ContainingCsectSymbolIndex", AuxEntPtr->SectionLen);
++    W.printNumber("ContainingCsectSymbolIndex", AuxEntPtr->SectionOrLength);
+   else
+-    W.printNumber("SectionLen", AuxEntPtr->SectionLen);
++    W.printNumber("SectionLen", AuxEntPtr->SectionOrLength);
+   W.printHex("ParameterHashIndex", AuxEntPtr->ParameterHashIndex);
+   W.printHex("TypeChkSectNum", AuxEntPtr->TypeChkSectNum);
+   // Print out symbol alignment and type.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68650.224078.patch
Type: text/x-patch
Size: 3365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191009/ab3ac85d/attachment.bin>