[PATCH] D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC)

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 03:33:03 PDT 2019


rengolin added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6472
 
+bool LoopVectorizationPlanner::tryToInterleaveMemory(
+    const InterleaveGroup<Instruction> *IG, VFRange &Range) {
----------------
Other try{something} functions return a recipe pointer, while this one returns a boolean.

If you rename this to "check" or "can" (instead of try), then you shouldn't clamp the range.

I'm not sure what's best here, but this way looks a bit odd.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68577/new/

https://reviews.llvm.org/D68577





More information about the llvm-commits mailing list