[PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

Wed Oct 9 00:38:34 PDT 2019

mstorsjo marked an inline comment as done.
mstorsjo added a comment.

In D68134#1700453 <https://reviews.llvm.org/D68134#1700453>, @amccarth wrote:

> LGTM after one question.

Thanks! I'll hold off committing for a bit still, as I might try to add more options to the microsoft demangler, to match the previous output.

================
Comment at: lldb/lit/SymbolFile/PDB/udt-layout.test:1
 REQUIRES: system-windows, lld
 RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp
----------------
amccarth wrote:
> Is `system-windows` still required after you've removed the dependency on dbghelp?
Yes, this test depends on the system-provided PDB support, so it needs to run on windows.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68134/new/

https://reviews.llvm.org/D68134