[PATCH] D68680: [dsymutil] Fix handling of common symbols in multiple object files.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: friss.
Herald added a subscriber: aprantl.
Herald added a project: LLVM.

For common symbols the linker emits only a single symbol entry in the debug map. This caused dsymutil to not relocate common symbols when linking DWARF coming form object files that did not have this entry. This patch fixes that by keeping track of common symbols in the object files and synthesizing a debug map entry for them using the address from the main binary.


Repository:
  rL LLVM

https://reviews.llvm.org/D68680

Files:
  llvm/test/tools/dsymutil/Inputs/private/tmp/common/com
  llvm/test/tools/dsymutil/Inputs/private/tmp/common/com1.o
  llvm/test/tools/dsymutil/Inputs/private/tmp/common/com2.o
  llvm/test/tools/dsymutil/X86/common-sym-multi.test
  llvm/tools/dsymutil/MachODebugMapParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68680.223972.patch
Type: text/x-patch
Size: 4306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191009/92132af5/attachment.bin>