[PATCH] D68559: [RISCV] Support fast calling convention

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 11:26:15 PDT 2019


shiva0217 added a comment.

In D68559#1699606 <https://reviews.llvm.org/D68559#1699606>, @lenary wrote:

> I like this change.
>
> `fastcc` is LLVM-internal only, right? Checking that we don't have to care about splitting operands that don't fit into registers, or any other psABI details, right?


Yes, to my understanding, `fastcc` doesn't need to care about psABI details.

In D68559#1699842 <https://reviews.llvm.org/D68559#1699842>, @jrtc27 wrote:

> I wonder whether it would be nicer to add `CC_RISCV_FastCC` as a function, much like `CC_RISCV`, instead, to match the current code style.


Ok, the code style has been synced and it also easier to extend when we support RV32E in the future, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68559/new/

https://reviews.llvm.org/D68559





More information about the llvm-commits mailing list