[PATCH] D68636: [llvm-readobj] - Refine the LLVM-style output to be consistent.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 08:07:41 PDT 2019


jhenderson added a comment.

In D68636#1699484 <https://reviews.llvm.org/D68636#1699484>, @grimar wrote:

> In D68636#1699479 <https://reviews.llvm.org/D68636#1699479>, @jhenderson wrote:
>
> > Did you remember to run LLD tests? I'd expect to see changes there...
>
>
> Sure. That will be a separate change, once we agree with LLVM side.


Just to clarify, are you still using the SVN layout rather than the monorepo? Using the monorepo would allow having all the changes in the same patch.

Aside from the discussion on the titles of Version data, this looks good to me. I don't have a strong preference whichever way is used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68636/new/

https://reviews.llvm.org/D68636





More information about the llvm-commits mailing list