[PATCH] D68133: [Symbolize] Use the local MSVC C++ demangler instead of relying on dbghelp. NFC.

Tue Oct 8 12:59:37 PDT 2019

mstorsjo added a comment.

In D68133#1700276 <https://reviews.llvm.org/D68133#1700276>, @thakis wrote:

> That links is dead. Which customization is needed here?

Ah crap, I should have quoted the relevant bits...

IIRC, it at least had extra `public:` at the start of the symbol, extra return type and calling convention specifiers. D68134 <https://reviews.llvm.org/D68134> has a more concrete case of what needs to change in LLDB if the llvm demangler is used as-is there.

> microsoftDemangle() already gets a Flags argument; we can just add more flags to it.

Oh, that's nice! Then this shoudln't probably be too big a deal to extend.

In D68133#1700277 <https://reviews.llvm.org/D68133#1700277>, @thakis wrote:

> But again, maybe the tests are just overly strict here?

I think for this particular case, for the fuzzer sanitizer's backtrace disambiguation log, there might be a risk that something is expecting to process the log, which might not be ready to handle extra unexpected keywords. I might be overly cautious though.

In the LLDB case, a concern was voiced that some parts of LLDB might try to parse the demangled symbol names, and not expect those extra keywords there.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68133/new/

https://reviews.llvm.org/D68133