[PATCH] D68202: [LLVM IR] Add `vscale` as a symbolic constant.
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 8 12:12:43 PDT 2019
cameron.mcinally added a comment.
Looks pretty good. This could probably use some tests in `TypeAndConstantValueParsing` of `llvm/unittests/AsmParser/AsmParserTest.cpp`. In particular, an `isa<VScale>(...)` test would be good. And maybe a negative test to make sure something like `<undef x 2 x f64>` can't be parsed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68202/new/
https://reviews.llvm.org/D68202
More information about the llvm-commits
mailing list