[PATCH] D68203: [SelectionDAG][SVE] Add ISD node for VSCALE.

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 11:44:32 PDT 2019


cameron.mcinally added a comment.

What happens if we see IR like:

  %1 = mul i16 vscale, -2

Would that be promoted to i32 through `PromoteIntRes_VSCALE(...)`?



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5141
+    }
+    LLVM_FALLTHROUGH;
   case ISD::SRA:
----------------
This should probably have a test. Same for ISD::MUL.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68203/new/

https://reviews.llvm.org/D68203





More information about the llvm-commits mailing list