[PATCH] D68639: [MachineScheduler] Add a flag to enable scheduling of cfi instructions

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:445
+/// If the option CFIInstructionScheduling is not set, cfi instructions act as
+/// scheduling boundaries, otherwise they do. This allows to schedule cfi
+/// instructions.
----------------
"If <something>, <they> act as scheduling boundaries, otherwise they do."  There seems to be a "not" missing somewhere.



================
Comment at: llvm/lib/CodeGen/ScheduleDAGInstrs.cpp:825
+    }
+
     SUnit *SU = MISUnitMap[&MI];
----------------
I realize you are planning to rework this to handle CFI and DBG instructions more in the same way.  But the tests don't appear to exercise the case of having a mix of CFI and DBG instructions, and I am not sure the current code will correctly handle all cases where CFI and DBG instructions are adjacent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68639/new/

https://reviews.llvm.org/D68639