[PATCH] D66887: [test-suite][WIP] Add GCC C Torture Suite as External Test Suite

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 08:35:16 PDT 2019


lenary added a comment.

In D66887#1676164 <https://reviews.llvm.org/D66887#1676164>, @kristof.beyls wrote:

> Were you planning once you commit to quickly add skip lists for other architectures too so that all public bots for all architectures will keep on passing?


Sorry, I missed addressing this.

There are two options:

1. I do nothing, people see that tests are failing and help me update the CMakeLists tests to skip. I think this would happen very quickly, as there would be failing tests.
2. I add a `if(ARCH MATCHES "x86" OR ARCH MATCHES "riscv")` around the `add_subdirectory(...)` in `SingleSource/Regression/C/CMakeLists.txt`. This will mean no errors, but I don't have a way of testing on other architectures so it could take a while for the torture suite to be supported by other architectures.

I'm not sure of the best way forward. If we want to avoid breakage: 2; if we're optimising for maximal test coverage: 1.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66887/new/

https://reviews.llvm.org/D66887





More information about the llvm-commits mailing list