[PATCH] D66887: [test-suite][WIP] Add GCC C Torture Suite as External Test Suite

Tue Oct 8 08:16:49 PDT 2019

kristof.beyls added a comment.

Thanks for persevering Sam.

I think the latest changes look good.
I only have 2 more minor nits, see below. After those are addressed, I think this will be fine to commit.

Thanks!

================
Comment at: SingleSource/Regression/C/gcc-c-torture/README:14-17
+# Licensing
+
+The testcases in SingleSource/Regression/C/gcc-c-torture/execute are covered by
+the GPL. See the files whose names start with COPYING for copying permission.
----------------
Given licensing information is also present in SingleSource/Regression/C/gcc-c-torture/execute/LICENSE.TXT and called out in the top-level LICENSE.TXT file in the test-suite, I don't think there's much value in repeating the information here too. Maybe best to delete this part?

================
Comment at: SingleSource/Regression/C/gcc-c-torture/execute/LICENCE.TXT:1-2
+The testcases in this directory are covered by the GPL. See the files whose
+names start with COPYING for copying permission.
----------------
it seems the file name here is still LICENCE.TXT rather than LICENSE.TXT, which would be preferred for consistency with the rest of the test-suite?

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66887/new/

https://reviews.llvm.org/D66887