[PATCH] D68636: [llvm-readobj] - Refine the LLVM-style output to be consistent.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.
Herald added a subscriber: wuzish.

Did you remember to run LLD tests? I'd expect to see changes there...



================
Comment at: tools/llvm-readobj/DwarfCFIEHPrinter.h:102
                                            uint64_t EHFrameHdrSize) const {
-  ListScope L(W, "EH_FRAME Header");
+  ListScope L(W, "EHFrameHeader");
   W.startLine() << format("Address: 0x%" PRIx64 "\n", EHFrameHdrAddress);
----------------
The data printed isn't a list, because it prints some metadata. I think this should be a dictionary too.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:5128
   {
-    DictScope D(W, "ElfHeader");
+    ListScope D(W, "ElfHeader");
     {
----------------
I don't think the ElfHeader should be a ListScope: it's not a list, but a dictionary (unlike, say, symbols).


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:5598
                                                 const Elf_Shdr *Sec) {
-  DictScope SS(W, "Version symbols");
+  ListScope SS(W, "VersionSymbols");
   if (!Sec)
----------------
Ditto, though I'm wondering here why the VersionSymbols data includes stuff to do with its section header? If it didn't have that stuff, it would be a list.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68636/new/

https://reviews.llvm.org/D68636