[PATCH] D68639: [MachineScheduler] Add a flag to enable scheduling of cfi instructions

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I've not looked to closely yet, but isn't that basically the same we do for debug values? If that's the case, I think we should consider unifying the code to handle debug & CFI. Specifically, would it be possible to just extend the current handling of debug instructions to also handle CFI instructions? That should some renaming and a few code changes. I think.



================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:449
+  /// boundaries
+  if (CFIInstructionScheduling && MI->isCFIInstruction()) {
+    return false;
----------------
Can that be folded into the return, like the other conditions? Also, please update the comment with details about CFIInstructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68639/new/

https://reviews.llvm.org/D68639