[PATCH] D68400: [NFC][TTI] Add Alignment for isLegalMasked[Load/Store]

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 06:51:39 PDT 2019


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4543
     return isa<LoadInst>(I) ?
-        !(isLegalMaskedLoad(Ty, Ptr)  || isLegalMaskedGather(Ty))
-      : !(isLegalMaskedStore(Ty, Ptr) || isLegalMaskedScatter(Ty));
+        !(isLegalMaskedLoad(Ty, Ptr, Alignment) || isLegalMaskedGather(Ty))
+      : !(isLegalMaskedStore(Ty, Ptr, Alignment) || isLegalMaskedScatter(Ty));
----------------
Does this need to be a MaybeAlign(Alignment)? Because the constructor is explicit, as far as I understand (hence, needs to look like the others).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68400/new/

https://reviews.llvm.org/D68400





More information about the llvm-commits mailing list