[PATCH] D68352: [lld] Don't create hints-section if Hint/Name Table is empty

Stefan Schmidt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 02:31:44 PDT 2019


thrimbor added a comment.

> So, you are creating an executable that has an import table that has only ordinals. Is my understanding correct? Indeed, that condition is rare and I've thought of that case before when I implemented this part.

Yes, that's what we were having issues with.

> I think your fix is correct. Does all tests still pass? Please run `ninja check-all` (or equivalent).

I ran `make check-lld` (and now `make check-all` as well, just to be sure), and all tests passed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68352/new/

https://reviews.llvm.org/D68352





More information about the llvm-commits mailing list