[PATCH] D68579: [HardwareLoops] Optimisation remarks

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:247
   for (Loop::iterator I = L->begin(), E = L->end(); I != E; ++I)
     if (TryConvertLoop(*I))
       return true; // Stop search.
----------------
Maybe can add a report here, Parent hardware loop does not support containing a nested hardware loop?


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:251
   HardwareLoopInfo HWLoopInfo(L);
   if (!HWLoopInfo.canAnalyze(*LI))
     return false;
----------------
And also here? Invalid loop for example the one which contains irreducible control flow?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68579/new/

https://reviews.llvm.org/D68579