[PATCH] D68441: Ignore --export-dynamic if --relocatable is given

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 00:49:11 PDT 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with 2 nits.



================
Comment at: lld/test/ELF/driver.test:54
+## Attempt to use -shared and -pie together
 ## Attempt to use -shared and -pie together
 # RUN: not ld.lld -shared -pie %t -o %tfail 2>&1 | FileCheck -check-prefix=ERR7 %s
----------------
Remove this duplication.


================
Comment at: lld/test/ELF/driver.test:77
+## Attempt to use -r and --export-dynamic together
+# RUN: not ld.lld -r -export-dynamic %t -o %tfail 2>&1 | FileCheck -check-prefix=ERR12 %s
+# ERR12: -r and --export-dynamic may not be used together
----------------
-o %tfail -> -o /dev/null


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68441/new/

https://reviews.llvm.org/D68441





More information about the llvm-commits mailing list