[PATCH] D68629: [llvm-exegesis] Finish plumbing the `Config` field.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 00:11:02 PDT 2019


courbet created this revision.
courbet added a reviewer: gchatelet.
Herald added a subscriber: tschuett.
Herald added a project: LLVM.

Right now there are no snippet generators that emit the `Config` Field,
but I plan to add it to investigate LEA operands for PR32326.

What was broken was:

- `Config` Was not propagated up until the BenchmarkResult::Key.
- Clustering should really consider different configs as measuring different things, so we should stabilize on (Opcode, Config) instead of just Opcode.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68629

Files:
  llvm/test/tools/llvm-exegesis/X86/analysis-cluster-stabilization-config.test
  llvm/tools/llvm-exegesis/lib/BenchmarkCode.h
  llvm/tools/llvm-exegesis/lib/BenchmarkResult.h
  llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
  llvm/tools/llvm-exegesis/lib/Clustering.cpp
  llvm/tools/llvm-exegesis/lib/CodeTemplate.h
  llvm/tools/llvm-exegesis/lib/SnippetFile.cpp
  llvm/tools/llvm-exegesis/lib/SnippetGenerator.cpp
  llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68629.223790.patch
Type: text/x-patch
Size: 14537 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191008/54fb3860/attachment.bin>


More information about the llvm-commits mailing list