[PATCH] D10548: Teach LTOModule to emit linker flags for dllexported symbols, plus interface cleanup.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1038-1041
+  if (TT.isKnownWindowsMSVCEnvironment())
+    OS << " /EXPORT:";
+  else
+    OS << " -export:";
----------------
This code is now new, but I wonder if we need to distinguish MinGW and MSVC here because they both recognize `-EXPORT`. I believe in many projects option `/foo` and `-foo` are used interchangeably.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1057-1060
+    if (TT.isKnownWindowsMSVCEnvironment())
+      OS << ",DATA";
+    else
+      OS << ",data";
----------------
Ditto -- I believe both should work with `DATA`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D10548/new/

https://reviews.llvm.org/D10548