[PATCH] D68352: [lld] Don't create hints-section if Hint/Name Table is empty

Mon Oct 7 21:08:42 PDT 2019

ruiu added a comment.

So, you are creating an executable that has an import table that has only ordinals. Is my understanding correct? Indeed, that condition is rare and I've thought of that case before when I implemented this part.

I think your fix is correct. Does all tests still pass? Please run `ninja check-all` (or equivalent).

================
Comment at: lld/test/COFF/imports-ordinal-only.s:5
+# RUN: llvm-mc -triple=i386-pc-win32 %s -filetype=obj -o %t.obj
+# RUN: lld-link -out:%t.exe -entry:main -subsystem:console -safeseh:no -debug %t.obj %t-implib.a
+
----------------
I'd dump the import table to verify that a correct import table is actually created in the resulting executable.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68352/new/

https://reviews.llvm.org/D68352