[PATCH] D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

LGTM modulo the postDominates comment.



================
Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:501
+
+  return ABB == BBB || PDT->dominates(ABB, BBB);
+}
----------------
I'm worried about the case when A and B in the same basic block, but in a opposite order - i.e. one lifetime ends when control enters the basic block, and a new one starts before it exits. I've never seen it happen in practice, but it seems to be valid IR.

I think you need to iterate over instructions here, same as DominatorTree::dominates does.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68469/new/

https://reviews.llvm.org/D68469