[PATCH] D67867: [libc] Add few docs and implementation of strcpy and strcat.

Mon Oct 7 15:06:41 PDT 2019

jyknight added a comment.

In D67867#1698273 <https://reviews.llvm.org/D67867#1698273>, @abrachet wrote:

> In D67867#1696908 <https://reviews.llvm.org/D67867#1696908>, @MaskRay wrote:
>
> > The commit was done in a hurry. For the initial commit of a brand new project that sets up the project hierarchy, this seems to have received fewer than enough thumbs up. Many points raised in the review process were just shrugged off.
>
>
> I don't know if it matters anymore because this was committed but I agree with @MaskRay. His suggestion of using `llvm-objcopy` to rename the symbols for tests makes much more sense to me. I haven't seen a libc that does testing in an ergonomic way and this suggestion seems the best to me, frankly.
>
> There is a lot going on here, it's hard to follow it all in one patch, and I think some comments got lost because of this. I feel like a lot of big design decisions were made here, did I miss something on the libc-dev mailing list?

FWIW -- llvm project policy is that both pre and post-commit reviews must be addressed.

That this is now committed does not change anything w.r.t. needing to respond to outstanding comments.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67867/new/

https://reviews.llvm.org/D67867