[PATCH] D67749: [AArch64] Stackframe accesses to SVE objects.

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:3366
+}
+
 int llvm::isAArch64FrameOffsetLegal(const MachineInstr &MI,
----------------
efriedma wrote:
> cameron.mcinally wrote:
> > I'm not an LLVM coding standards expert, but does this need an llvm_unreachable()? I think it does...
> The reason we add llvm_unreachable() after switches in some cases is related to warnings.  Some compilers warn about a missing return after a switch that covers every named enum value, but not every possible enum value.  That case doesn't apply here: the switch has a "default".
Ah, ok. I thought that it was protection in case the the switch is changed in the future. The X86 backend has a few switches with default cases that also have unreachable after them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67749/new/

https://reviews.llvm.org/D67749