[PATCH] D68582: GlobalISel: Add target pre-isel instructions

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 10:30:56 PDT 2019


qcolombet accepted this revision.
qcolombet added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/RegBankSelect.cpp:693
+      //
+      // TODO: Remove opcode check. Should copy and others be marked pre-isel?
+      if (isTargetSpecificOpcode(MI.getOpcode()) && !MI.isPreISelOpcode())
----------------
Replying to the TODO: No, I don't think they should because after ISel the expectation is that pre-isel opcodes are not present anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68582/new/

https://reviews.llvm.org/D68582





More information about the llvm-commits mailing list