[PATCH] D68584: Fix Calling Convention through aliases
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 7 10:18:36 PDT 2019
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:251
// Make sure the call and the callee agree on calling convention.
- if (llvm::Function *dtorFn =
- dyn_cast<llvm::Function>(dtor.getCallee()->stripPointerCasts()))
+ if (llvm::Function *dtorFn = dyn_cast<llvm::Function>(
+ dtor.getCallee()->stripPointerCastsAndAliases()))
----------------
Nit: while here you could change this to `auto *`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68584/new/
https://reviews.llvm.org/D68584
More information about the llvm-commits
mailing list