[PATCH] D68465: [DebugInfo] Trim call-clobbered location list entries when tuning for GDB

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Debugger tuning should not be used directly this way.  There should be a DwarfDebug flag, and a CL option, and the default set in the DwarfDebug ctor based on tuning.  This allows the defaulting to work how you want, but can be overridden easily for experimentation and testing.  There are lots of examples of doing this in the ctor already.  Also, if it turns out some other debugger also needs this, it's trivial to fix up the ctor to handle it with no code changes needed elsewhere.

@dblaikie I'm also not clear what you're suggestion about .debug_addr entry plus offset.  DW_LLE_offset_pair does this, derived from the base address, which ought to be available for any given function, assuming DWARF v5.  Can you explain more clearly what's missing?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68465/new/

https://reviews.llvm.org/D68465