[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 09:05:27 PDT 2019


cameron.mcinally marked an inline comment as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/trunk/include/llvm-c/Core.h:1523-1524
       macro(UndefValue)                     \
     macro(Instruction)                      \
       macro(BinaryOperator)                 \
       macro(CallInst)                       \
----------------
cameron.mcinally wrote:
> lebedev.ri wrote:
> > @cameron.mcinally Should anything have been added here for `UnaryOperator` ? 
> Yes, I believe you're correct. Will add that under a separate Diff. Thanks.
@lebedev.ri, do you know of any existing tests for these macros? I see a number of uses, but no unittests/etc.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53877/new/

https://reviews.llvm.org/D53877





More information about the llvm-commits mailing list