[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally marked 2 inline comments as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/trunk/include/llvm-c/Core.h:1523-1524
       macro(UndefValue)                     \
     macro(Instruction)                      \
       macro(BinaryOperator)                 \
       macro(CallInst)                       \
----------------
lebedev.ri wrote:
> @cameron.mcinally Should anything have been added here for `UnaryOperator` ? 
Yes, I believe you're correct. Will add that under a separate Diff. Thanks.


================
Comment at: llvm/trunk/include/llvm/Bitcode/LLVMBitCodes.h:373
+enum UnaryOpcodes {
+  UNOP_NEG = 0
+};
----------------
lebedev.ri wrote:
> @cameron.mcinally also, shouldn't this be `UNOP_FNEG`?
I'm not sure. The BINOPs are overloaded for INT/FP types. E.g. BINOP_ADD is also FP. I suppose there are no plans for an INT UNOP_NEG though. Do you feel strongly about this change?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53877/new/

https://reviews.llvm.org/D53877