[PATCH] D67879: [LNT] Python 3 support: import object when inheriting from it

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 07:59:08 PDT 2019


thopre abandoned this revision.
thopre added a comment.

In D67879#1697652 <https://reviews.llvm.org/D67879#1697652>, @hubert.reinterpretcast wrote:

> My understanding is that this patch has no effect for Python 3. In Python 2, `object` from `builtins` (as provided by the `future` package) is used to enable use of some Python 3 coding patterns. Absent further changes that make use of such enablement, I am not sure that this patch is necessary. If this patch is needed to support later patches, then I suggest applying the fixer at that point. Applying the fixer before applying D67882 <https://reviews.llvm.org/D67882> seems odd anyway.


I wholly agree (see what I wrote in D67882 <https://reviews.llvm.org/D67882>). And yes the ordering in which futurize do these changes is odd.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67879/new/

https://reviews.llvm.org/D67879





More information about the llvm-commits mailing list