[PATCH] D68570: Unify the two CRC implementations
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 7 07:43:08 PDT 2019
hans added a comment.
In D68570#1697588 <https://reviews.llvm.org/D68570#1697588>, @joerg wrote:
> Why go back to the large tables for crc32? Just because JamCRC had that bug doesn't mean it should persist.
Because just using the table is much simpler and we already have it: no need for any run-time initialization and fancy code like call_once. Why do you consider it a bug? Generating a constant table like this at run-time -- again and again for each invocation of the program -- seems less than ideal to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68570/new/
https://reviews.llvm.org/D68570
More information about the llvm-commits
mailing list