[PATCH] D68566: [ARM] VQADD instructions

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 07:24:21 PDT 2019


dmgreen marked an inline comment as done.
dmgreen added a comment.

The usat version can be idiom recognised from C:
https://godbolt.org/z/9knBnP
ssat is more difficult like I mentioned, but I don't think it should be impossible to do the same thing there too.



================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1624
+  foreach instr = [MVE_VQADDu8, MVE_VQADDu16, MVE_VQADDu32] in
+    foreach VT = [instr.VT] in
+      def : Pat<(VT (uaddsat (VT MQPR:$Qm), (VT MQPR:$Qn))),
----------------
SjoerdMeijer wrote:
> And looking at this, I almost start to like tablegen. :-)
This is from D67158. The idea is that an intrinsic can be easily added in here, same as for vadds in that patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68566/new/

https://reviews.llvm.org/D68566





More information about the llvm-commits mailing list