[PATCH] D68470: [InstCombine][NFC] dropRedundantMaskingOfLeftShiftInput(): change how we deal with mask

Mon Oct 7 06:54:30 PDT 2019

lebedev.ri added a comment.

In D68470#1697437 <https://reviews.llvm.org/D68470#1697437>, @spatel wrote:

> In D68470#1697370 <https://reviews.llvm.org/D68470#1697370>, @lebedev.ri wrote:
>
> > In D68470#1697275 <https://reviews.llvm.org/D68470#1697275>, @spatel wrote:
> >
> > > The diff as shown includes D68239 <https://reviews.llvm.org/D68239> rather than building on top of it? Commit the other patch and rebase, so we are current with trunk?
> >
> >
> > No, this is fully properly rebased.
>
>
> I see. I was distracted by the cosmetic diffs caused by different indentation. This is already NFC, so there's not much point in making sub-patches. LGTM.

Thank you for the review!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68470/new/

https://reviews.llvm.org/D68470