[PATCH] D68472: [test] Depend on C.UTF-8 dependency for mri-utf8.test

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 06:50:29 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/mri-nonascii.test:15
+
+# Use input redirection to work around problems launching processess that
+# include arguments with non-ascii characters.
----------------
hubert.reinterpretcast wrote:
> Minor nit: s/processess/processes/;
What problems do you work around? POSIX.1-2017 3.282 Portable Filename Character Set consists of the classical Latin alphabet, 0~9, <period>, <underscore>, and <hyphen-minus>. a filename consisting of the UTF-8 byte sequence 0xc2 0xa3 (£) may be disallowed by some implementations but it is unlikely that the implementation can arbitrarily reinterpret the byte sequence and cause the test to fail.

I suggest deleting the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68472/new/

https://reviews.llvm.org/D68472





More information about the llvm-commits mailing list