[PATCH] D68572: gn build: use better triple on windows

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 06:07:19 PDT 2019


thakis created this revision.
thakis added a reviewer: hans.
Herald added a project: LLVM.

The CMake build uses "x86_64-pc-windows-msvc". The "-msvc" suffix is
important because e.g. clang/test/lit.cfg.py matches against the
suffix "windows-msvc" to compute the presence of the "ms-sdk" and
the absence of the "LP64" feature.


https://reviews.llvm.org/D68572

Files:
  llvm/utils/gn/secondary/llvm/triples.gni


Index: llvm/utils/gn/secondary/llvm/triples.gni
===================================================================
--- llvm/utils/gn/secondary/llvm/triples.gni
+++ llvm/utils/gn/secondary/llvm/triples.gni
@@ -10,7 +10,7 @@
   } else if (current_os == "mac") {
     llvm_current_triple = "x86_64-apple-darwin"
   } else if (current_os == "win") {
-    llvm_current_triple = "x86_64-pc-windows"
+    llvm_current_triple = "x86_64-pc-windows-msvc"
   }
 } else if (current_cpu == "arm64") {
   if (current_os == "android") {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68572.223539.patch
Type: text/x-patch
Size: 523 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191007/2dff091d/attachment.bin>


More information about the llvm-commits mailing list