[PATCH] D47751: [lsan] Do not check for leaks in the forked process

[Vitaly Buka via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Changes Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb89704fa6f6f: [lsan] Do not check for leaks in the forked process (authored by vitalybuka).
Herald added projects: Sanitizers, LLVM.
Herald added a subscriber: Sanitizers.

Changed prior to commit:
  https://reviews.llvm.org/D47751?vs=150012&id=223496#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47751/new/

https://reviews.llvm.org/D47751

Files:
  compiler-rt/lib/lsan/lsan_common.cc
  compiler-rt/test/lsan/TestCases/Linux/fork_with_threads.cc


Index: compiler-rt/test/lsan/TestCases/Linux/fork_with_threads.cc
===================================================================
--- /dev/null
+++ compiler-rt/test/lsan/TestCases/Linux/fork_with_threads.cc
@@ -0,0 +1,35 @@
+// Test forked process does not run lsan.
+// RUN: %clangxx_lsan %s -o %t && %run %t 2>&1 | FileCheck %s
+
+#include <pthread.h>
+#include <stdlib.h>
+#include <sys/wait.h>
+#include <unistd.h>
+
+static pthread_barrier_t barrier;
+
+// CHECK-NOT: SUMMARY: {{(Leak|Address)}}Sanitizer:
+static void *thread_func(void *arg) {
+  void *buffer = malloc(1337);
+  pthread_barrier_wait(&barrier);
+  for (;;)
+    pthread_yield();
+  return 0;
+}
+
+int main() {
+  pthread_barrier_init(&barrier, 0, 2);
+  pthread_t tid;
+  int res = pthread_create(&tid, 0, thread_func, 0);
+  pthread_barrier_wait(&barrier);
+  pthread_barrier_destroy(&barrier);
+
+  pid_t pid = fork();
+  if (pid > 0) {
+    int status = 0;
+    waitpid(pid, &status, 0);
+  }
+  return 0;
+}
+
+// CHECK: WARNING: LeakSanitizer is disabled in forked process
Index: compiler-rt/lib/lsan/lsan_common.cc
===================================================================
--- compiler-rt/lib/lsan/lsan_common.cc
+++ compiler-rt/lib/lsan/lsan_common.cc
@@ -100,6 +100,8 @@
 
 static InternalMmapVector<RootRegion> *root_regions;
 
+static uptr initialized_for_pid;
+
 InternalMmapVector<RootRegion> const *GetRootRegions() { return root_regions; }
 
 void InitializeRootRegions() {
@@ -113,6 +115,7 @@
 }
 
 void InitCommonLsan() {
+  initialized_for_pid = internal_getpid();
   InitializeRootRegions();
   if (common_flags()->detect_leaks) {
     // Initialization which can fail or print warnings should only be done if
@@ -568,6 +571,12 @@
 static bool CheckForLeaks() {
   if (&__lsan_is_turned_off && __lsan_is_turned_off())
       return false;
+  if (initialized_for_pid != internal_getpid()) {
+    // If process was forked and it had threads we fail to detect references
+    // from other threads.
+    Report("WARNING: LeakSanitizer is disabled in forked process.\n");
+    return false;
+  }
   EnsureMainThreadIDIsCorrect();
   CheckForLeaksParam param;
   param.success = false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47751.223496.patch
Type: text/x-patch
Size: 2186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191007/8e5b1993/attachment.bin>