[PATCH] D29011: [IR] Add Freeze instruction

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 02:26:26 PDT 2019


aqjune marked 9 inline comments as done.
aqjune added a comment.

Updated the patch so UnaryOperator is used for Instruction::Freeze op.
Currently I see an error from Phabricator while uploading a new diff:

  Unhandled Exception ("PhabricatorFileUploadException")	
  Unable to write file: failed to write to temporary directory.

I'll retry uploading it later.



================
Comment at: include/llvm/CodeGen/GlobalISel/IRTranslator.h:487
+  bool translateFreeze(const User &U, MachineIRBuilder &MIRBuilder) {
+    return false;
+  }
----------------
lebedev.ri wrote:
> Is this a correctness issue?
> Or does returning `false` here results in IRTranslator "aborting"?
Yep, returning false makes it abort, if my understanding is correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29011/new/

https://reviews.llvm.org/D29011





More information about the llvm-commits mailing list