[PATCH] D68494: [PATCH 11/38] [noalias] D9377: llvm.noalias - don't block EarlyCSE

Jeroen Dobbelaere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 6 12:18:29 PDT 2019


jeroen.dobbelaere marked an inline comment as done.
jeroen.dobbelaere added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:937
+    if (match(Inst, m_CombineOr(m_Intrinsic<Intrinsic::sideeffect>(),
+                                m_Intrinsic<Intrinsic::assume>()))) {
+      LLVM_DEBUG(dbgs() << "EarlyCSE skipping intrinsic: " << *Inst << '\n');
----------------
lebedev.ri wrote:
> This looks incorrect to me.
> Did you mean `Intrinsic::noalias` ?
> Or does `Intrinsic::noalias` identify as `Intrinsic::assume`?
Yes, that should have been Intrinsic::noalias.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68494/new/

https://reviews.llvm.org/D68494





More information about the llvm-commits mailing list