[PATCH] D68453: TableGen: Allow 'a+b' in TableGen language

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

This doesn't raise any concerns with me but i don't believe i'm most qualified to review this :)
Missing `llvm/docs/TableGen/LangIntro.rst`, `llvm/docs/TableGen/LangRef.rst`, `llvm/utils/kate/llvm-tablegen.xml` changes.



================
Comment at: llvm/lib/TableGen/TGParser.cpp:2184-2186
+      Init *RHSResult = ParseValue(CurRec, ItemType, ParseNameMode);
+      Result = BinOpInit::get(BinOpInit::ADD, LHS, RHSResult,
+                                    IntRecTy::get())->Fold(CurRec);
----------------
Do you want to make any sanity checks about types of lhs, rhs, final type?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68453/new/

https://reviews.llvm.org/D68453