[PATCH] D68539: fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 5 06:25:47 PDT 2019


Daniel599 created this revision.
Daniel599 added reviewers: llvm-commits, alexfh, alexfh_.
Daniel599 added projects: clang-tools-extra, LLVM.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Daniel599 edited the summary of this revision.

This patch fixes 'Bug 41120'
https://bugs.llvm.org/show_bug.cgi?id=41120
When clang-tidy encounter a fixup name that would become a keyword, it just display a warning with reason and doesn't attempt to fix it.
Please let me know if this patch is OK, Thanks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68539

Files:
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
  clang-tools-extra/test/clang-tidy/readability-identifier-naming-bugfix-name-conflicts.cpp
  clang/include/clang/Basic/IdentifierTable.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68539.223370.patch
Type: text/x-patch
Size: 6515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191005/f87f825c/attachment.bin>


More information about the llvm-commits mailing list