[PATCH] D68529: [lit] Move argument parsing/validation to separate file

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 5 01:49:18 PDT 2019


serge-sans-paille added a comment.

LGTM otherwise



================
Comment at: llvm/utils/lit/lit/main.py:237
     elif opts.incremental:
-        sort_by_incremental_cache(run)
+        run.tests.sort(key = by_mtime, reverse = True)
     else:
----------------
nitpicking: PEP8 recommends ``sort(key=by_mtime, reverse=True)``


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68529/new/

https://reviews.llvm.org/D68529





More information about the llvm-commits mailing list