[PATCH] D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:587
+  PostDominatorTreeWrapperPass &PDTWP = getAnalysis<PostDominatorTreeWrapperPass>();
+  PostDominatorTree &PDT = PDTWP.getPostDomTree();
+
----------------
Now we compute domtree and postdomtree for all functions, even at -O0, even when building without memory tagging. Is it OK?

This can get resolved by switching to the new pass manager in the backend. Do you know if there are any plans to do so?


================
Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:592
+  Instruction *Base = insertBaseTaggedPointer(
+      Allocas, NumInterestingAllocas > 1 ? &DT : nullptr);
 
----------------
If we definitely have DT, then just pass it unconditionally.


================
Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:626
+        SmallVector<Instruction *, 8> ReachableRetVec;
+        unsigned numCoveredExits = 0;
+        for (auto &RI : RetVec) {
----------------
Variable names start with an uppercase letter.

http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68469/new/

https://reviews.llvm.org/D68469