[PATCH] D68446: [X86] Remove isel patterns for mask vpcmpgt/vpcmpeq. Switch vpcmp to these based on the immediate in MCInstLower

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked 2 inline comments as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:3145
 // Patterns for comparing 128/256-bit integer vectors using 512-bit instruction.
 multiclass axv512_icmp_packed_no_vlx_lowering<PatFrag Frag, PatFrag Frag_su,
                                               string InstStr,
----------------
RKSimon wrote:
> Can this be removed as well?
yes


================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:3168
 
 multiclass axv512_icmp_packed_rmb_no_vlx_lowering<PatFrag Frag, PatFrag Frag_su,
                                                   string InstStr,
----------------
RKSimon wrote:
> Can this be removed as well?
Yes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68446/new/

https://reviews.llvm.org/D68446