[PATCH] D68239: [InstCombine] dropRedundantMaskingOfLeftShiftInput(): change how we deal with mask

Fri Oct 4 08:58:38 PDT 2019

lebedev.ri added a comment.

In D68239#1694814 <https://reviews.llvm.org/D68239#1694814>, @spatel wrote:

> In D68239#1693270 <https://reviews.llvm.org/D68239#1693270>, @lebedev.ri wrote:
>
> > I'd be okay with either spliting this up further if wanted, or moving this particular patch
> >  into post-commit review mode; the only worrying thing to me here is the `sanitizeUndefsTo()` itself.
>
>
> I'm a patch minimalist, so if we can split this up, let's do it.

Cool, will post in a sec..

> We should not use "sanitize" in the function name because that term already has a special meaning in the clang/LLVM world.

Any suggestions? `replaceUndefsWith`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68239/new/

https://reviews.llvm.org/D68239