[PATCH] D68425: [NFC] [FileCheck] Fix init of objects in unit tests
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 4 08:46:41 PDT 2019
thopre added a comment.
In D68425#1694745 <https://reviews.llvm.org/D68425#1694745>, @probinson wrote:
> In D68425#1694675 <https://reviews.llvm.org/D68425#1694675>, @thopre wrote:
>
> > Ok to commit this revised change? I double checked that I ran the unit tests this time and all tests pass.
>
>
> For simple changes to fix a bot breakage, it's generally fine to just recommit the updated fix; people also like to see a comment in the commit log for the recommit that says something about what's different this time or why it's okay to recommit.
Noted, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68425/new/
https://reviews.llvm.org/D68425
More information about the llvm-commits
mailing list