[PATCH] D68383: [llvm-readelf/llvm-objdump] - Improve/refactor the implementation of SHT_LLVM_ADDRSIG section dumping.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 08:37:56 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/tools/llvm-readobj/elf-addrsig.test:31
+## Check that llvm-readobj dumps any SHT_LLVM_ADDRSIG section when --all
+## is specified for LLVM style, but not for GNU style
+## TODO: Refine the llvm-readelf check when GNU-style dumping is implemented.
----------------
Nit: missing trailing full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68383/new/

https://reviews.llvm.org/D68383





More information about the llvm-commits mailing list