[PATCH] D68082: [SCEV] Don't add Predicates with OptForSize

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 08:35:13 PDT 2019


SjoerdMeijer added a comment.

> The earlier "fix at the core" thought was for LV to do something along these lines:

Okay, sorry for misunderstanding! The "core" for me was the place that produces predicates in the first place, which is happening by in `PSE.getAsAddRec(Ptr)` called by `getPtrStride()`. It was my understanding and line of thought that not producing them, return nullptr for `getAsAddRec()`, was the most clean and most minimal change, but I am not insisting at all of course! So thanks for your suggestions, I will prepare a patch based on this. If @sanjoy in the mean time does think this is an interesting change, then I could change again.

Thanks again for the help


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68082/new/

https://reviews.llvm.org/D68082





More information about the llvm-commits mailing list