[PATCH] D68359: [LegalizeTypes][X86] When splitting a vselect for type legalization, don't split a setcc condition if the setcc input is legal and vXi1 conditions are supported

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp:529-531
+      if (Cond.getValueType().getVectorElementType() == MVT::i1 &&
+          isTypeLegal(CondLHSVT) &&
+          getSetCCResultType(CondLHSVT) == Cond.getValueType())
----------------
I'm not familiar with how we make this kind of choice, but we could leave off the MVT::i1 clause and get the same results.
Ie, if the setcc has legal types and result, then it's a legal op independent of the exact vector element type?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68359/new/

https://reviews.llvm.org/D68359