[llvm] r373737 - [llvm-ar][test] Clarified comment

Owen Reynolds via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 05:26:25 PDT 2019


Author: gbreynoo
Date: Fri Oct  4 05:26:25 2019
New Revision: 373737

URL: http://llvm.org/viewvc/llvm-project?rev=373737&view=rev
Log:
[llvm-ar][test] Clarified comment

The test is dependant on the installation of the en_US.UTF-8
locale. The reasoning for this is clarified in the amended comment.

Modified:
    llvm/trunk/test/tools/llvm-ar/mri-utf8.test

Modified: llvm/trunk/test/tools/llvm-ar/mri-utf8.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/mri-utf8.test?rev=373737&r1=373736&r2=373737&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/mri-utf8.test (original)
+++ llvm/trunk/test/tools/llvm-ar/mri-utf8.test Fri Oct  4 05:26:25 2019
@@ -16,4 +16,8 @@ RUN: cd %t/extracted && llvm-ar x %t/mri
 # include arguments with non-ascii characters.
 # Python on Linux defaults to ASCII encoding unless the
 # environment specifies otherwise, so it is explicitly set.
+# The reliance the test has on this locale is not ideal,
+# however alternate solutions have been difficult due to 
+# behaviour differences with python 2 vs python 3,
+# and linux vs windows.
 RUN: env LANG=en_US.UTF-8 %python -c "assert open(u'\U000000A3.txt', 'rb').read() == b'contents\n'"




More information about the llvm-commits mailing list