[PATCH] D68418: [test] Remove locale dependency for mri-utf8.test

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 03:43:53 PDT 2019


gbreynoo added a comment.

You are correct that the locale is required to pass on linux. I had some trouble with this test as the behaviour of python in this area differs between linux / windows and python 2 / python 3. For example this fix appears to be fine for linux, however Windows with python 2 fails:

  Traceback (most recent call last):
    File "<string>", line 1, in <module>
  IOError: [Errno 2] No such file or directory: '\xc2\xa3.txt'

I do not like the reliance on the locale however the upstream buildbots all appear to have it installed. Maybe the test should be split into a windows test and a linux test?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68418/new/

https://reviews.llvm.org/D68418





More information about the llvm-commits mailing list